Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "coprocessor: Exceed action for copiterator (#17324)" #18704

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Revert "coprocessor: Exceed action for copiterator (#17324)" #18704

merged 3 commits into from
Jul 21, 2020

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Jul 21, 2020 •
edited by XuHuaiyu
Loading

Reverts #18392

#18392 has these following problems

  1. when checkWorkerOOM is true, a task will be lost
  2. the size of respCh is still 15. When the upstream data is slow, the memory will still fill up the channel (the same when keepOrder is true)
  3. When oomAction reduces the concurrency, copIterator waits for the upstream to receive data before releasing the memory. When the concurrency drops to 1 but the memory is not released and a consume comes, unexpected OOM happens.

Release note

@SunRunAway SunRunAway requested review from Yisaer and XuHuaiyu July 21, 2020 06:09
@XuHuaiyu
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
@SunRunAway SunRunAway added sig/execution SIG execution and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 21, 2020
Yisaer
Yisaer reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@Yisaer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack).

wshwsh12
wshwsh12 reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 21, 2020
@XuHuaiyu XuHuaiyu mentioned this pull request Jul 21, 2020
Closed
@XuHuaiyu
Copy link
Contributor

/rebuild

@jebter
Copy link

jebter commented Jul 21, 2020

/run-unit-test

@jebter
Copy link

jebter commented Jul 21, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18705

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@SunRunAway merge failed.

@jebter jebter merged commit 762e4a4 into release-4.0 Jul 21, 2020
@jebter jebter deleted the revert-18392-release-4.0-a5829ae5e616 branch July 21, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@Yisaer Yisaer Yisaer left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SunRunAway @XuHuaiyu @ti-srebot @jebter @Yisaer @wshwsh12