-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add proposal for global index #18982
Conversation
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
PTAL @tiancaiamao |
|
||
#### Drop Table | ||
|
||
Add extra one range deletion to clean global indexes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just dropping the key range started with tableID
prefix should work.
|
||
## Implementation | ||
|
||
DDL operations will be implemented first. Plan and executor supports will be implemented after [new PartitionTable executor](https://github.com/pingcap/tidb/issues/18016) is completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's almost done already, you can just try the latest master code.
I just comment on some spells. The content looks good to me. |
Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
LGTM @coocood @wjhuang2016 do you need more take look? |
LGTM |
/run-check_release_note |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
/rebuild |
@ldeng-ustc merge failed. |
|
||
#### Drop Partition | ||
|
||
In global index, all index entries in a partition is not continuous. It is impossible to delete all index entries of a partition in a single range deletion. So, we add a reorg state (just like add index), which scan records in the partition and remove relative index entries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the redundant blank space in single range
What problem does this PR solve?
This PR adds proposal for global index support.
What is changed and how it works?
None.
Release note