planner: support out join in broadcast join #18988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
approved these changes
Aug 5, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@windtalker merge failed. |
Codecov Report
@@ Coverage Diff @@
## master #18988 +/- ##
===========================================
Coverage 79.4990% 79.4990%
===========================================
Files 546 546
Lines 148486 148486
===========================================
Hits 118045 118045
Misses 20972 20972
Partials 9469 9469 |
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 1, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19664 |
zz-jason
pushed a commit
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
TiFlash support broadcast join, and TiDB could push down joins to TiFlash to improve join queries, however, it only support inner join, for left/right join, TiDB can not push down to TiFlash.
What is changed and how it works?
Push down left/right join to TiFlash since it already support left/right join in TiFlash.
Related changes
Check List
Tests
Side effects
Release note