-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: change dispatch failed log to info level #19217
Conversation
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #19217 +/- ##
================================================
+ Coverage 79.0731% 79.0854% +0.0122%
================================================
Files 550 549 -1
Lines 149277 149183 -94
================================================
- Hits 118038 117982 -56
+ Misses 21703 21681 -22
+ Partials 9536 9520 -16 |
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
PTAL @nullnotnil @crazycs520 |
LGTM |
@nullnotnil,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.You are not a reviewer or committer or co-leader or leader. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jackysp should we cherry-pick this PR to release branches? |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@jackysp merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@jackysp merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.0 in PR #19453 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #19454 |
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
Issue Number: Part of #19053 (does not close issue)
Problem Summary:
Dispatching error is the error from the client, the server doesn't do anything wrong.
What is changed and how it works?
Proposal: xxx
What's Changed:
Change it to info level
How it Works:
Related changes
Check List
Tests
Release note