Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: change dispatch failed log to info level #19217

Merged
merged 5 commits into from
Aug 26, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Aug 14, 2020

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: Part of #19053 (does not close issue)

Problem Summary:
Dispatching error is the error from the client, the server doesn't do anything wrong.

What is changed and how it works?

Proposal: xxx

What's Changed:
Change it to info level

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Release note

  • Invalid SQL statements (dispatch errors) have been changed from an Error to an Info message in the server log file.

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
server/conn.go Outdated Show resolved Hide resolved
@jackysp jackysp changed the title server: change dispatch error to warning server: change dispatch failed log to warning level Aug 14, 2020
@jackysp jackysp requested review from crazycs520 and a user August 14, 2020 12:31
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #19217 into master will increase coverage by 0.0122%.
The diff coverage is 100.0000%.

@@               Coverage Diff                @@
##             master     #19217        +/-   ##
================================================
+ Coverage   79.0731%   79.0854%   +0.0122%     
================================================
  Files           550        549         -1     
  Lines        149277     149183        -94     
================================================
- Hits         118038     117982        -56     
+ Misses        21703      21681        -22     
+ Partials       9536       9520        -16     

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp
Copy link
Member Author

jackysp commented Aug 15, 2020

PTAL @nullnotnil @crazycs520

@ghost ghost changed the title server: change dispatch failed log to warning level server: change dispatch failed log to info level Aug 15, 2020
@ghost
Copy link

ghost commented Aug 15, 2020

LGTM

@ti-srebot
Copy link
Contributor

@nullnotnil,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.You are not a reviewer or committer or co-leader or leader.

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 24, 2020
@zz-jason
Copy link
Member

@jackysp should we cherry-pick this PR to release branches?

@zz-jason
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19433
  • 19446

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@jackysp merge failed.

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19433

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@jackysp merge failed.

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19433

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 7c5cfd7 into pingcap:master Aug 26, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #19453

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19454

ti-srebot added a commit that referenced this pull request Sep 1, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@jackysp jackysp deleted the dispatch_warn branch November 25, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants