planner: make a copy of column before modifying its InOperand #19472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
eurekaka
requested review from
qw4990,
SunRunAway,
winoros and
XuHuaiyu
and removed request for
a team,
qw4990 and
SunRunAway
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
ti-srebot
approved these changes
Aug 26, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@eurekaka merge failed. |
|
/run-all-tests |
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19477 |
eurekaka
added a commit
that referenced
this pull request
Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Kenan Yao <cauchy1992@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19423
Problem Summary:
Incorrect of anti-semi-join query caused by incorrect
OtherConditionsof the LogicalJoin plan.What is changed and how it works?
What's Changed:
After #13406,
LogicalProjectionwould not allocate newColumnfor column -> column projection, so if we directly modifyInOperandof aColumn, it may effect the filters in the subquery. Make a copy of this column before modifying this field.How it Works:
The filters in the subquery would stay untouched, so they can correctly be put into
EqualConditions/OtherConditionslater.Related changes
Check List
Tests
Side effects
N/A
Release note