Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: reset not null flag when Apply convert to Join (#19567) #19628

Merged
merged 3 commits into from
Sep 1, 2020
Merged

planner: reset not null flag when Apply convert to Join (#19567) #19628

merged 3 commits into from
Sep 1, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19567 to release-4.0

What problem does this PR solve?

Issue Number: close #19504

Problem Summary:

  1. Apply->Agg convert to Agg->LeftOuterJoin, but not reset not null flag.
  2. Eliminate Agg to Projection 1 -> Column, instand of ifnull(column, 0) -> Column.https://github.com/pingcap/tidb/blob/master/planner/core/rule_aggregation_elimination.go#L111

What is changed and how it works?

Proposal: xxx

What's Changed:

  1. Reset not null flag.
  2. Rebuild aggfuncs to use these columns.

How it Works:

Related changes

  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix wrong result for aggregation count(col)

@wshwsh12 @ti-srebot
cherry pick pingcap#19567 to release-4.0
a56b6cd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Aug 31, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 31, 2020
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Sep 1, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
zz-jason
zz-jason approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2020
@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 18950
  • 18801
  • 19445
  • 19518
  • 19452
  • 19439
  • 19465

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit fe1298b into pingcap:release-4.0 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@wshwsh12 wshwsh12

Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @XuHuaiyu @zz-jason @wshwsh12