fix read failure from system tables tiflash_segments and tiflash_tables when some tiflash node is down
#19714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidezhu
changed the title
tiflash_tables and tiflash_segments when tls is enabledtiflash_segments and tiflash_tables when some tiflash node is down
crazycs520
reviewed
Sep 2, 2020
|
/run-all-tests |
4 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
ti-srebot
approved these changes
Sep 3, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@lidezhu merge failed. |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/merge |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19748 |
zz-jason
pushed a commit
that referenced
this pull request
Sep 4, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18701
Problem Summary: When some tiflash node is down, tidb will still try to fetch data from them and this makes the query failed.
What is changed and how it works?
What's Changed: Check whether tiflash http_port is open before fetch data from them.
Related changes
Check List
Tests
follow the steps in this issue: Select from system tables
tiflash_segmentsandtiflash_tablesdoesn't work correctly when some tiflash node is down #18701 and make sure the result meets the expectation.Release note
tiflash_segmentsandtiflash_tableswhen some tiflash node is down