Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix file exists errors in tests for select into outfile #19717

Merged
merged 2 commits into from
Sep 2, 2020
Merged

executor: fix file exists errors in tests for select into outfile #19717

merged 2 commits into from
Sep 2, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 2, 2020 •
edited by SunRunAway
Loading

What problem does this PR solve?

Issue Number: close #19718, close #19337

Problem Summary: executor: fix file exists errors in tests for select into outfile

What is changed and how it works?

Use random file names to avoid file name conflict.

Check List

Tests

  • Unit test

Release note

  • executor: fix file exists errors in tests for select into outfile

@qw4990 qw4990 requested a review from a team as a code owner September 2, 2020 09:47
@qw4990 qw4990 requested review from SunRunAway, winoros and XuHuaiyu and removed request for a team September 2, 2020 09:47
winoros
winoros reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2020
Yisaer
Yisaer approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM close #19718

@ti-srebot
Copy link
Contributor

@Yisaer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: execution(slack).

@lysu lysu mentioned this pull request Sep 2, 2020
Closed
@lysu
Copy link
Contributor

lysu commented Sep 2, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 2, 2020
@lysu
Copy link
Contributor

lysu commented Sep 2, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@qw4990 merge failed.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 2, 2020

/run-integration-common-test
/run-sqllogic-test-2

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 2, 2020

/run-integration-common-test
/run-sqllogic-test-1
/run-sqllogic-test-2

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 2, 2020

/run-integration-common-test
/run-sqllogic-test-1
/run-sqllogic-test-2

@lysu
Copy link
Contributor

lysu commented Sep 2, 2020

/run-integration-common-test
/run-sqllogic-test-2

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 2, 2020

/run-integration-common-test
/run-sqllogic-test-2

@winoros winoros merged commit 0fd81a8 into pingcap:master Sep 2, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2020
@qw4990 @ti-srebot
cherry pick pingcap#19717 to release-4.0
77abc15 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 2, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19725

@winoros winoros mentioned this pull request Sep 3, 2020
Closed
winoros pushed a commit that referenced this pull request Sep 3, 2020
@ti-srebot @qw4990
executor: fix file exists errors in tests for select into outfile (#…
06fbed8 
…19717) (#19725)

Co-authored-by: Yuanjia Zhang <zhangyuanjia@pingcap.com>
@Yisaer Yisaer mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@Yisaer Yisaer Yisaer approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@qw4990 @ti-srebot @lysu @winoros @Yisaer