Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fallback vectorized control expressions (#19367) #19749

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19367 to release-4.0


What problem does this PR solve?

Issue Number: close #17725

Problem Summary: the vectorized execution runs each branch, some of them cause unnecessary errors. In fact, the later computation depends on the results of formers, the vectorization of laters should consider the formers. This needs to change the interface of vectorization of expressions.

We add fallback mechnism to avoid unnecessary warnings or errors. If errors/warnings occur for unsure branches, we fallback the vectorization to scalar execution.

In addition, the constant folding case is in #19675.

What is changed and how it works?

Proposal: xxx

What's Changed: disable vectroization in the source file of control expressions.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • fallback vectorize control expressions

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@fzhedu
Copy link
Contributor

fzhedu commented Sep 3, 2020

/run-all-tests

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 4, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 4, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 4, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@SunRunAway SunRunAway merged commit f5f8043 into pingcap:release-4.0 Sep 4, 2020
@SunRunAway SunRunAway deleted the release-4.0-d8b3d329cd94 branch September 4, 2020 07:23
@lilinghai
Copy link
Contributor

/run-tics-test

@lilinghai
Copy link
Contributor

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants