Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support new aggregate funtion APPROX_PERCENTILE #19799

Merged
merged 45 commits into from
Sep 24, 2020
Merged

executor: support new aggregate funtion APPROX_PERCENTILE #19799

merged 45 commits into from
Sep 24, 2020

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Sep 4, 2020 •
edited by ti-srebot
Loading

What problem does this PR solve?

Issue Number: #19405

Problem Summary:

What is changed and how it works?

What's Changed:

  • Add a new aggregate function APPROX_PERCENTILE

How it Works:

  • Fetch a column, and perform k-th smallest element algorithm on it to find specified percentile.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: TODO
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • Support new aggregate function APPROX_PERCENTILE

@leiysky leiysky requested review from a team as code owners September 4, 2020 08:25
@leiysky leiysky requested review from fzhedu and lzmhhh123 and removed request for a team September 4, 2020 08:25
@sre-bot
Copy link
Contributor

sre-bot commented Sep 4, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

2 similar comments
@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@leiysky leiysky closed this Sep 10, 2020
@leiysky leiysky reopened this Sep 14, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 14, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@leiysky leiysky changed the title [WIP] executor: support new aggregate funtion APPROX_PERCENTILE executor: support new aggregate funtion APPROX_PERCENTILE Sep 15, 2020
@leiysky
Copy link
Contributor Author

leiysky commented Sep 15, 2020

/label needs-cherry-pick-4.0

@leiysky
Copy link
Contributor Author

leiysky commented Sep 15, 2020

/label type/new-feature

@winoros
Copy link
Member

winoros commented Sep 15, 2020

Please fill in the pull request template.

@leiysky
Copy link
Contributor Author

leiysky commented Sep 15, 2020

/run-all-tests

fzhedu
fzhedu previously approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost LGTM

executor/aggfuncs/builder.go Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2020
fzhedu
fzhedu approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leiysky
Copy link
Contributor Author

leiysky commented Sep 24, 2020

@lzmhhh123 PTAL

@leiysky
Copy link
Contributor Author

leiysky commented Sep 24, 2020

/run-all-tests

2 similar comments
@leiysky
Copy link
Contributor Author

leiysky commented Sep 24, 2020

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Sep 24, 2020

/run-all-tests

lzmhhh123
lzmhhh123 reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 24, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit aceecf0 into pingcap:master Sep 24, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 24, 2020
@leiysky @ti-srebot
cherry pick pingcap#19799 to release-4.0
840495f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 24, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20197

@leiysky leiysky deleted the feature/percentile-function branch September 24, 2020 09:00
ti-srebot added a commit that referenced this pull request Oct 19, 2020
@ti-srebot
executor: support new aggregate function APPROX_PERCENTILE (#19799) (#…
cae843b 
…20197)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@lysu lysu mentioned this pull request Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@fzhedu fzhedu fzhedu approved these changes

Assignees
No one assigned
Labels
challenge-program component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@leiysky @sre-bot @CLAassistant @winoros @fzhedu @lzmhhh123 @ti-srebot