execution: fix different error code from MySQL when inserting incorrect bigint value #19854

TszKitLo40 · 2020-09-08T02:41:26Z

What problem does this PR solve?

Issue Number: close #17832

Problem Summary:
fix different error code from MySQL when inserting incorrect bigint value

What's Changed:
Return types.ErrTruncated when the data is truncated in the cast value function.

Check List

Tests

Manual test (Same steps in the issue)

Release note

fix different error code from MySQL when inserting incorrect bigint value

…e same problem in aggfunc_test

…ct bigint value

wjhuang2016

Please add a unit test for this change.

…ct bigint value

…mUsage

…anch 'master' of https://github.com/pingcap/tidb

…m/TszKitLo40/tidb into incorrect-error-code-bigint-value

TszKitLo40 · 2020-09-09T09:18:50Z

My commit failed to pass the tests. I have no idea how to know whether the error should be thrown between ErrWarnDataTruncated and ErrTruncatedWrongValueForField. @wjhuang2016 @SunRunAway Can you give me some advice?

SunRunAway · 2020-09-10T12:27:48Z

The failed test case says,

[2020-09-09T09:27:58.004Z] ----------------------------------------------------------------------

[2020-09-09T09:27:58.004Z] FAIL: executor_test.go:2915: testSuite.TestEmptyEnum

[2020-09-09T09:27:58.004Z] 

[2020-09-09T09:27:58.004Z] executor_test.go:2922:

[2020-09-09T09:27:58.004Z]     c.Assert(terror.ErrorEqual(err, table.ErrTruncatedWrongValueForField), IsTrue, Commentf("err %v", err))

[2020-09-09T09:27:58.004Z] ... obtained bool = false

[2020-09-09T09:27:58.004Z] ... err [table:1265]Data truncated for column 'e' at row 1

[2020-09-09T09:27:58.004Z] 

[2020-09-09T09:27:58.004Z] 

[2020-09-09T09:27:58.004Z] ----------------------------------------------------------------------

Could you help fix it? @TszKitLo40

TszKitLo40 · 2020-09-10T15:37:30Z

The failed test case says,

[2020-09-09T09:27:58.004Z] ----------------------------------------------------------------------

[2020-09-09T09:27:58.004Z] FAIL: executor_test.go:2915: testSuite.TestEmptyEnum

[2020-09-09T09:27:58.004Z] 

[2020-09-09T09:27:58.004Z] executor_test.go:2922:

[2020-09-09T09:27:58.004Z]     c.Assert(terror.ErrorEqual(err, table.ErrTruncatedWrongValueForField), IsTrue, Commentf("err %v", err))

[2020-09-09T09:27:58.004Z] ... obtained bool = false

[2020-09-09T09:27:58.004Z] ... err [table:1265]Data truncated for column 'e' at row 1

[2020-09-09T09:27:58.004Z] 

[2020-09-09T09:27:58.004Z] 

[2020-09-09T09:27:58.004Z] ----------------------------------------------------------------------

Could you help fix it? @TszKitLo40

I am not sure whether my implementation is correct. What do you think of my implementation?

wshwsh12

Please resolve conflict.

…m/TszKitLo40/tidb into incorrect-error-code-bigint-value

TszKitLo40 · 2020-09-14T08:37:52Z

Please resolve conflict.

I have resolved it.

TszKitLo40 · 2020-09-17T11:48:53Z

I found that the bug is that '2 ^ 31 - 1' would be truncated to 2. ErrTruncatedWrongVal error would be thrown and I change it to ErrorTruncated. I am not sure whether my idea is correct.

mmyj · 2020-10-15T08:12:43Z

table/column.go

@@ -177,7 +177,7 @@ func CastValue(ctx sessionctx.Context, val types.Datum, col *model.ColumnInfo, r
 		if err1 != nil {
 			logutil.BgLogger().Warn("Datum ToString failed", zap.Stringer("Datum", val), zap.Error(err1))
 		}
-		err = sc.HandleTruncate(types.ErrTruncatedWrongVal.GenWithStackByArgs(col.FieldType.CompactStr(), str))
+		err = sc.HandleTruncate(types.ErrTruncated.GenWithStackByArgs(col.FieldType.CompactStr(), str))


Modifying the code here will cause upper-level misjudgment errors and cause other problems. We should find other ways to resolved this issue.

zz-jason · 2021-02-09T08:14:39Z

I'm going to close this PR since it hasn't been updated for a long time. feel free to reopen if you want to continue with it. thank you for your contribution.

alfredlu and others added 12 commits September 7, 2020 10:09

Implement meldata for rank funcs to track memUsage

395f403

refactor the code

d005ccd

Add comment

0d17e2c

Add unit tests

a467be6

reformat the code

4ebdbe1

Add mem delta without checking whether the row is null

f96d3c0

Reformat the code

be19bae

Fix check dev

6c1875b

Remove useless variable

6c9343c

check for the errors first and then check for the memDelta and fix th…

eb21ba1

…e same problem in aggfunc_test

Remove the useless code.

7eba262

execution: fix different error code from MySQL when inserting incorre…

56b733e

…ct bigint value

ti-srebot added the contribution This PR is from a community contributor. label Sep 8, 2020

wjhuang2016 reviewed Sep 8, 2020

View reviewed changes

Add unit test

bb85afa

TszKitLo40 requested a review from a team as a code owner September 8, 2020 11:25

TszKitLo40 requested review from wshwsh12 and removed request for a team September 8, 2020 11:25

github-actions bot added the sig/execution SIG execution label Sep 8, 2020

Fix check_dev

191a8b2

TszKitLo40 force-pushed the incorrect-error-code-bigint-value branch from 2e8351e to 191a8b2 Compare September 8, 2020 11:35

TszKitLo40 added 9 commits September 8, 2020 19:43

execution: fix different error code from MySQL when inserting incorre…

7f9e054

…ct bigint value

Add unit test

e62e18a

Fix check_dev

82c1819

executor: nitpick for implementing meldata for rank funcs to track me…

ddb0592

…mUsage

Merge branch 'master' into agg-mem-rank

a797a1f

Merge branch 'master' into agg-mem-rank

7fbc368

Resolve the problem.

201db26

Merge branch 'agg-mem-rank' of https://github.com/TszKitLo40/tidb; br…

68d62fe

…anch 'master' of https://github.com/pingcap/tidb

Merge branch 'master' into incorrect-error-code-bigint-value

25a61da

Merge branch 'incorrect-error-code-bigint-value' of https://github.co…

d4e4ec8

…m/TszKitLo40/tidb into incorrect-error-code-bigint-value

bugfix

901b1b0

TszKitLo40 added 2 commits September 10, 2020 23:23

Resolve the issue

8ab904a

Merge branch 'master' into incorrect-error-code-bigint-value

80f161d

github-actions bot added the component/expression label Sep 10, 2020

Fix check_dev

71cf073

qw4990 added 2 commits September 11, 2020 11:33

Merge branch 'master' into incorrect-error-code-bigint-value

71ad4ad

Merge branch 'master' into incorrect-error-code-bigint-value

b283317

qw4990 requested a review from wjhuang2016 September 11, 2020 06:04

wshwsh12 reviewed Sep 14, 2020

View reviewed changes

TszKitLo40 added 2 commits September 14, 2020 16:29

Merge branch 'master' into incorrect-error-code-bigint-value

1e6b324

Merge branch 'incorrect-error-code-bigint-value' of https://github.co…

5ad90ad

…m/TszKitLo40/tidb into incorrect-error-code-bigint-value

Nitpick

1dc9ce4

ti-srebot added challenge-program difficulty/easy labels Sep 18, 2020

mmyj reviewed Oct 15, 2020

View reviewed changes

ichn-hu mentioned this pull request Nov 3, 2020

Welcome to contribute #20804

Closed

zz-jason closed this Feb 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

execution: fix different error code from MySQL when inserting incorrect bigint value #19854

execution: fix different error code from MySQL when inserting incorrect bigint value #19854

TszKitLo40 commented Sep 8, 2020 •

edited by ti-srebot

Loading

wjhuang2016 left a comment

TszKitLo40 commented Sep 9, 2020 •

edited

Loading

SunRunAway commented Sep 10, 2020

TszKitLo40 commented Sep 10, 2020

wshwsh12 left a comment

TszKitLo40 commented Sep 14, 2020

TszKitLo40 commented Sep 17, 2020

mmyj Oct 15, 2020

zz-jason commented Feb 9, 2021

execution: fix different error code from MySQL when inserting incorrect bigint value #19854

execution: fix different error code from MySQL when inserting incorrect bigint value #19854

Conversation

TszKitLo40 commented Sep 8, 2020 • edited by ti-srebot Loading

Check List

Release note

wjhuang2016 left a comment

Choose a reason for hiding this comment

TszKitLo40 commented Sep 9, 2020 • edited Loading

SunRunAway commented Sep 10, 2020

TszKitLo40 commented Sep 10, 2020

wshwsh12 left a comment

Choose a reason for hiding this comment

TszKitLo40 commented Sep 14, 2020

TszKitLo40 commented Sep 17, 2020

mmyj Oct 15, 2020

Choose a reason for hiding this comment

zz-jason commented Feb 9, 2021

TszKitLo40 commented Sep 8, 2020 •

edited by ti-srebot

Loading

TszKitLo40 commented Sep 9, 2020 •

edited

Loading