-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix wrong behavior for max/min
on ENUM/SET column (#19552)
#19869
Merged
qw4990
merged 4 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-9047a9c8814b
Sep 8, 2020
Merged
executor: fix wrong behavior for max/min
on ENUM/SET column (#19552)
#19869
qw4990
merged 4 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-9047a9c8814b
Sep 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
contribution
This PR is from a community contributor.
type/4.0-cherry-pick
labels
Sep 8, 2020
qw4990
reviewed
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
SunRunAway
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Sep 8, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 8, 2020
/run-all-tests |
@ti-srebot merge failed. |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution
This PR is from a community contributor.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19552 to release-4.0
What problem does this PR solve?
Issue Number: close #13961
Problem Summary:
max
/min
produces wrong result on ENUM & SET column.What is changed and how it works?
What's Changed:
Fix max/min implementation for ENUM/SET type.
How it Works:
Add max/min implementation for ENUM/SET type.
Related changes
pingcap/docs
/pingcap/docs-cn
:No.
No.
Check List
Tests
Side effects
MySQL produce MIN/MAX result on string value of ENUM/SET column, rather than index value. Which is in-consist with manual, and considered as a known issue.
Release note
max/min
on ENUM/SET column.