Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: enable inline projection for sort&topN #19900

Closed
wants to merge 63 commits into from
Closed

executor: enable inline projection for sort&topN #19900

wants to merge 63 commits into from

Conversation

hidehalo
Copy link
Contributor

@hidehalo hidehalo commented Sep 9, 2020 •
edited by XuHuaiyu
Loading

What problem does this PR solve?

Sort&TopN for #14428

Problem Summary:

Check List

Tests

  • UnitTest

Side effects

  • None

Release note

  • Enable inline projection for sort&topN executor

@hidehalo hidehalo requested a review from a team as a code owner September 9, 2020 07:51
@hidehalo hidehalo requested review from SunRunAway and removed request for a team September 9, 2020 07:51
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Sep 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@github-actions github-actions bot added the sig/execution SIG execution label Sep 9, 2020
@hidehalo
Copy link
Contributor Author

@SunRunAway PTAL, I am looking forward take this issue. xD

Yisaer
Yisaer reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. please add a unit test

executor/sort.go Outdated Show resolved Hide resolved
executor/builder.go Outdated Show resolved Hide resolved
@sre-bot
Copy link
Contributor

sre-bot commented Sep 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@sre-bot
Copy link
Contributor

sre-bot commented Sep 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@hidehalo
Copy link
Contributor Author

@Yisaer Very appreciate for your advices! PTAL, thx!

Yisaer
Yisaer reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, do you have any better idea about the adding unit test case? @SunRunAway

@hidehalo hidehalo mentioned this pull request Sep 18, 2020
Open
9 tasks
XuHuaiyu
XuHuaiyu reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a correctness test for this modification.
Like select b from t order by a, b
select b from t order by a, b limit 2
select a, sum(c) from t order by a, b, c
...

executor/builder.go Outdated Show resolved Hide resolved
executor/builder.go Outdated Show resolved Hide resolved
executor/sort.go Outdated Show resolved Hide resolved
executor/builder.go Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@hidehalo,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: execution(slack).

4 similar comments
@ti-srebot
Copy link
Contributor

@hidehalo,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: execution(slack).

@ti-srebot
Copy link
Contributor

@hidehalo,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: execution(slack).

@ti-srebot
Copy link
Contributor

@hidehalo,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: execution(slack).

@ti-srebot
Copy link
Contributor

@hidehalo,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: execution(slack).

@hidehalo
Copy link
Contributor Author

hidehalo commented Dec 9, 2020

/run-all-tests

@pingyu
Copy link
Contributor

pingyu commented Dec 9, 2020

Great !
Rest LGTM, except this point.
PTAL~ @SunRunAway

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 25, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2021
@hidehalo hidehalo force-pushed the inlineprojection-sort-topn branch from c6e7e23 to 7eb8f20 Compare March 16, 2021 03:18
@hidehalo
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Member

@hidehalo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2021
@hidehalo
Copy link
Contributor Author

@hidehalo: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

:)

@hidehalo
Copy link
Contributor Author

@SunRunAway @XuHuaiyu it's really hang up a while 🤣

@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 01:42
@guo-shaoge
Copy link
Collaborator

/uncc @XuHuaiyu

@tisonkun
Copy link
Contributor

@hidehalo I'm sorry for this PR to be stale. It conflicts a lot and I'd like to close for a new PR rebeased.

We undergo a personnel change and I think @SunRunAway doesn't act as a reviewer any more.

Sorry for the inactive community during this PR. I hope it would be better when a new PR comes.

@tisonkun tisonkun closed this Jul 29, 2021
@hidehalo
Copy link
Contributor Author

@hidehalo I'm sorry for this PR to be stale. It conflicts a lot and I'd like to close for a new PR rebeased.

We undergo a personnel change and I think @SunRunAway doesn't act as a reviewer any more.

Sorry for the inactive community during this PR. I hope it would be better when a new PR comes.

Thx for your attention!

@EricZequan EricZequan mentioned this pull request Dec 24, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@pingyu pingyu pingyu requested changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.