Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: add new scalar function IsTruthWithNull (#19621) #19903

Merged
merged 5 commits into from
Sep 21, 2020

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 9, 2020

cherry-pick #19621 to release-4.0


What problem does this PR solve?

Issue Number: close #17720, close #17476

Problem Summary: NewFunction can't get keepnull attributes for isture function.

What is changed and how it works?

Proposal: xxx

What's Changed:

  1. Add a new scalar function name IsTruthWithNull in parser.
  2. Use the function name to build ScalarFuncton in wrapWithIsTrue.

How it Works:

Related changes

  • Need to cherry-pick to the release branch 3.0,4.0

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix the behavior of rewrite ScalarFunction IsTure .

@ti-srebot
Copy link
Contributor Author

/run-all-tests

go.mod Outdated
@@ -32,7 +32,11 @@ require (
github.com/pingcap/goleveldb v0.0.0-20191226122134-f82aafb29989
github.com/pingcap/kvproto v0.0.0-20200818080353-7aaed8998596
github.com/pingcap/log v0.0.0-20200828042413-fce0951f1463
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wshwsh12 Please fix CI

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2020
@XuHuaiyu
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2020
@XuHuaiyu
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@imtbkcat
Copy link

/run-all-tests

@imtbkcat
Copy link

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @imtbkcat, you don't have permission to trigger auto merge event on this branch.

@XuHuaiyu XuHuaiyu merged commit 902347c into pingcap:release-4.0 Sep 21, 2020
@XuHuaiyu XuHuaiyu deleted the release-4.0-0c36203f1d73 branch September 21, 2020 05:50
@XuHuaiyu XuHuaiyu restored the release-4.0-0c36203f1d73 branch September 21, 2020 05:51
@XuHuaiyu XuHuaiyu deleted the release-4.0-0c36203f1d73 branch September 21, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge-program component/expression sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants