Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix cluster_slow_query time type in streaming request bug (#19938) #19943

Merged
merged 3 commits into from
Sep 16, 2020
Merged

executor: fix cluster_slow_query time type in streaming request bug (#19938) #19943

merged 3 commits into from
Sep 16, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19938 to release-4.0

What problem does this PR solve?

close #19937

What is changed and how it works?

The TIME column type of cluster_slow_query was wrong.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • Fix issue querying cluster_slow_query time type in streaming request bug.

@crazycs520 @ti-srebot
cherry pick pingcap#19938 to release-4.0
e9e254d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 11, 2020
Merged
@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Sep 11, 2020
@ti-srebot ti-srebot added this to the 4.0.7 milestone Sep 11, 2020
@crazycs520
Copy link
Contributor

/run-common-test
/run-integration-common-test
/run-integration-compatibility-test

@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor

/run-all-tests

AilinKid
AilinKid reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2020
tangenta
tangenta reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 14, 2020
@crazycs520
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 16, 2020
@bb7133 bb7133 merged commit daf2656 into pingcap:release-4.0 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@AilinKid AilinKid AilinKid left review comments

@bb7133 bb7133 bb7133 approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@crazycs520 crazycs520

Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @crazycs520 @bb7133 @AilinKid @tangenta