-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add coprocessor cache hit ratio in explain analyze #19948
executor: add coprocessor cache hit ratio in explain analyze #19948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this a hit ratio, rather than a rate. These are often used interchangeably, but I try to be careful to use rate to refer to the number of misses over a time scale. i.e. 123 misses/s
Edit: Google seems to back me on this one. A rate is for comparing different units (such as cache misses over time):
A ratio is a comparison of two numbers or measurements. The numbers or measurements being compared are called the terms of the ratio. A rate is a special ratio in which the two terms are in different units.
Nice catch. |
@nullnotnil,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: execution(slack). |
Clear review, I meant to just dismiss previous (LGTM but I'm not a LGTM'er)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #19972 |
What problem does this PR solve?
Issue Number: close #17370
What is changed and how it works?
How it Works: add coprocessor cache hit rate in explain analyze.
here is an example:
another example with consecutive two same queries.
Related changes
Check List
Tests
Side effects
Release note