Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix query slow_query error when slow-log file not exist (#20000) #20051

Merged
merged 4 commits into from
Sep 21, 2020
Merged

executor: fix query slow_query error when slow-log file not exist (#20000) #20051

merged 4 commits into from
Sep 21, 2020

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 17, 2020 •
edited
Loading

cherry-pick #20000 to release-4.0

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Close #19985

> select count(*) from information_schema.cluster_slow_query;
(1105, 'other error: open tidb-slow.log: no such file or directory')

What is changed and how it works?

Ignore file not exist error when slow-log file error.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • Fix issue query slow_query error when slow-log file not exist

@crazycs520 @ti-srebot
cherry pick pingcap#20000 to release-4.0
2599af3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
@ti-srebot ti-srebot added sig/execution SIG execution type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Sep 17, 2020
@ti-srebot ti-srebot added this to the 4.0.7 milestone Sep 17, 2020
@crazycs520
Copy link
Contributor

/run-all-tests

wjhuang2016
wjhuang2016 reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2020
AilinKid
AilinKid reviewed Sep 18, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2020
tangenta
tangenta approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 18, 2020
@crazycs520
Copy link
Contributor

/run-all-tests

@bb7133 bb7133 merged commit aba9761 into pingcap:release-4.0 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@tangenta tangenta tangenta approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees

@crazycs520 crazycs520

Labels
challenge-program sig/execution SIG execution status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.7
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @crazycs520 @AilinKid @wjhuang2016 @tangenta @bb7133