infoschema: change data structure for lookup table by ID. #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngaut
reviewed
Nov 15, 2016
| func (b *Builder) copySchemaNames(oldIS *infoSchema) { | ||
| for k, v := range oldIS.schemaNameToID { | ||
| b.is.schemaNameToID[k] = v | ||
| func (b *Builder) copySchemasMap(oldIS *infoSchema) { |
ngaut
reviewed
Nov 15, 2016
| info.schemaNameToID[di.Name.L] = di.ID | ||
| schTbls := &schemaTables{ | ||
| dbInfo: di, | ||
| tables: make(map[string]table.Table), |
ngaut
reviewed
Nov 15, 2016
| info.schemas[infoSchemaDB.ID] = infoSchemaDB | ||
| infoSchemaTblNames := &schemaTables{ | ||
| dbInfo: infoSchemaDB, | ||
| tables: make(map[string]table.Table), |
ngaut
reviewed
Nov 15, 2016
| perfSchemaDB := perfHandle.GetDBMeta() | ||
| perfSchemaTblNames := &schemaTables{ | ||
| dbInfo: perfSchemaDB, | ||
| tables: make(map[string]table.Table), |
ngaut
reviewed
Nov 15, 2016
| // CopySortedTables copies sortedTables for old table and new table for later modification. | ||
| func (b *Builder) copySortedTables(oldTableID, newTableID int64) { | ||
| buckets := b.is.sortedTablesBuckets | ||
| if oldTableID != 0 { |
There was a problem hiding this comment.
Please define a constant as invalid table id.
ngaut
reviewed
Nov 15, 2016
| buckets[newTableID%bucketCount] = newSortedTables | ||
| } | ||
| } | ||
|
|
||
| // updateDBInfo clones a new DBInfo from old DBInfo, and update on the new one. | ||
| func (b *Builder) updateDBInfo(roDBInfo *model.DBInfo, oldTableID, newTableID int64) { | ||
| newDbInfo := new(model.DBInfo) | ||
| *newDbInfo = *roDBInfo |
coocood
force-pushed
the
coocood/split-table-array
branch
from
10ef81c to
543e474
Compare
ngaut
reviewed
Nov 15, 2016
| for _, tb := range tbList { | ||
| tbl := table.MockTableFromMeta(tb) | ||
| tableNames.tables[tb.Name.L] = tbl | ||
| bucketIdx := tb.ID % bucketCount |
There was a problem hiding this comment.
We should extract tb.ID % bucketCount to a hash function.
ngaut
reviewed
Nov 15, 2016
| // CopySortedTables copies sortedTables for old table and new table for later modification. | ||
| func (b *Builder) copySortedTables(oldTableID, newTableID int64) { | ||
| buckets := b.is.sortedTablesBuckets | ||
| if oldTableID != invalidTableID { |
There was a problem hiding this comment.
We should extract validation logic to a function.
coocood
force-pushed
the
coocood/split-table-array
branch
from
33a063e to
887f641
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 512 of table slice to lookup table by ID.
When schema is updated, only 1/512 of memory need to be allocated.