Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expressions: Support bin-to-uuid and uuid-to-bin #20140

Merged
merged 27 commits into from
Jun 30, 2021
Merged

expressions: Support bin-to-uuid and uuid-to-bin #20140

merged 27 commits into from
Jun 30, 2021

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Sep 22, 2020

What problem does this PR solve?

Issue Number: close #20119

Problem Summary:
Support bin-to-uuid and uuid-to-bin

What is changed and how it works?

What's Changed:
add uuidToBinFunctionClass and binToUuidFunctionClass

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • Support bin-to-uuid and uuid-to-bin

@b41sh
add uuid_to_bin bin_to_uuid
4c56c59
@b41sh
fix
f73bba0 
Signed-off-by: baishen <baishen2009@gmail.com>
@b41sh b41sh requested a review from a team as a code owner September 22, 2020 04:03
@b41sh b41sh requested review from qw4990 and removed request for a team September 22, 2020 04:03
@github-actions github-actions bot added the sig/execution SIG execution label Sep 24, 2020
@b41sh b41sh requested a review from a team as a code owner September 26, 2020 04:12
@b41sh b41sh requested review from winoros and removed request for a team September 26, 2020 04:12
qw4990
qw4990 reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2020
@qw4990 qw4990 requested a review from XuHuaiyu October 20, 2020 08:56
@b41sh
Copy link
Member Author

b41sh commented Mar 11, 2021

PTAL @XuHuaiyu @wshwsh12

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 7, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2021
XuHuaiyu
XuHuaiyu approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 30, 2021
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0aefb84

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 30, 2021
@ti-chi-bot ti-chi-bot merged commit 6063386 into pingcap:master Jun 30, 2021
@dveeden dveeden mentioned this pull request Jul 5, 2021
Closed
This was referenced Dec 1, 2021
Closed
Closed
@dveeden dveeden mentioned this pull request Feb 17, 2022
Merged
14 tasks
This was referenced Apr 27, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/expression sig/execution SIG execution size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support bin-to-uuid and uuid-to-bin
5 participants
@b41sh @qw4990 @ti-chi-bot @XuHuaiyu @ti-srebot