-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix corrupted default value for bit type column (#18036) #20339
Merged
ti-srebot
merged 8 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-6342fa6a5068
Nov 13, 2020
Merged
ddl: fix corrupted default value for bit type column (#18036) #20339
ti-srebot
merged 8 commits into
pingcap:release-3.0
from
ti-srebot:release-3.0-6342fa6a5068
Nov 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
sig/sql-infra
SIG: SQL Infra
type/3.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Oct 4, 2020
ti-srebot
requested review from
crazycs520,
djshow832,
wjhuang2016,
zimulala and
zz-jason
October 4, 2020 05:00
tangenta
added
the
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
label
Oct 14, 2020
Please resolve the conflicts @tangenta |
/run-check_dev |
Waiting for pingcap/parser#1090. |
/run-all-tests |
LGTM |
zz-jason
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Nov 13, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Nov 13, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
sig/sql-infra
SIG: SQL Infra
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18036 to release-3.0
What problem does this PR solve?
Issue Number: close #17641 close #17642
Problem Summary:
The
ColumnInfo.OriginDefaultValue
is corrupted when the column type isBIT
.BIT
type column values are stored as strings by JSON marshaling and read it by unmarshaling later. However, the data in a string can be changed in this case:If we store it as []byte, the problem disappeared. This is how
DefaultValueBit
works.The same problem exists in
OriginDefaultValue
. PR #12168 tried to restore theOriginDefaultValue
fromDefaultValueBit
in the getter, butOriginDefaultValue
is different fromDefaultValue
:OriginDefaultValue
is used to skip the backfilling phase ofAddColumn()
. If a column's default value is modified byALTER TABLE MODIFY COLUMN DEFAULT
, they are not equal anymore(see the example in #17641).What is changed and how it works?
This PR adds a field
OriginDefaultValueBit
toColumnInfo
, which borrows fromDefaultValueBit
to solve the problem completely.Proposal: xxx
What's Changed:
OriginDefaultValue
.How it Works:
If the column type is
BIT
, set/get the content withOriginDefaultValueBit
.Related changes
Check List
Tests
Side effects
Release note