-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add executor runtime info for explain for connection
statement (#19183)
#20384
Merged
ti-srebot
merged 7 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-17b7b5e8158e
Oct 22, 2020
Merged
*: add executor runtime info for explain for connection
statement (#19183)
#20384
ti-srebot
merged 7 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-17b7b5e8158e
Oct 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
challenge-program
contribution
This PR is from a community contributor.
difficulty/easy
sig/execution
SIG execution
type/4.0-cherry-pick
labels
Oct 10, 2020
qw4990
reviewed
Oct 19, 2020
This reverts commit c022ad3.
…lease-4.0-17b7b5e8158e
/run-all-tests |
Signed-off-by: crazycs520 <crazycs520@gmail.com>
/run-all-tests |
SunRunAway
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@qw4990 PTAL |
@crazycs520 documentation is needed. |
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Oct 22, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution
This PR is from a community contributor.
sig/execution
SIG execution
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19183 to release-4.0
What problem does this PR solve?
Issue Number: close #18233
Problem Summary:
add this runtime information in explain for connection statement.
Example:
When set @@tidb_enable_collect_execution_info=1;
When set @@tidb_enable_collect_execution_info=0;, Since TiDB doesn't collect runtime information, so
explan for connection
will also not display theexecutor info
.Check List
Tests
Side effects
Release note
explain for connection
result.