Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add projection if expand virtual generated column #20478

Merged
merged 12 commits into from
Dec 3, 2020
Merged

planner: add projection if expand virtual generated column #20478

merged 12 commits into from
Dec 3, 2020

Conversation

wjhuang2016
Copy link
Member

What problem does this PR solve?

Issue Number: close #20071

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • fix a bug that may cause panic if use partition and virtual generated column.

@wjhuang2016
1
507e91d 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
done
b178030 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 wjhuang2016 requested a review from a team as a code owner October 15, 2020 12:26
@wjhuang2016 wjhuang2016 requested review from eurekaka and removed request for a team October 15, 2020 12:26
eurekaka
eurekaka reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify and add the panic case in the issue as a unit test.

planner/core/task.go Show resolved Hide resolved
planner/core/exhaust_physical_plans.go Outdated Show resolved Hide resolved
planner/core/task.go Show resolved Hide resolved
@wjhuang2016
Merge branch 'master' of https://github.com/pingcap/tidb into fix_pro…
b4cfb88 
…j_parunion
@wjhuang2016
done
6a598a2 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 wjhuang2016 requested a review from a team as a code owner October 28, 2020 09:46
@wjhuang2016 wjhuang2016 requested review from wshwsh12 and removed request for a team October 28, 2020 09:46
@XuHuaiyu XuHuaiyu requested a review from eurekaka November 3, 2020 03:42
@ti-srebot
Copy link
Contributor

@eurekaka, @wshwsh12, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@eurekaka, @wshwsh12, PTAL.

@ti-srebot
Copy link
Contributor

@eurekaka, @wshwsh12, PTAL.

@wjhuang2016
done
972c753 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ichn-hu ichn-hu mentioned this pull request Nov 16, 2020
Closed
@wjhuang2016
Merge branch 'master' into fix_proj_parunion
c0cd11e
@wjhuang2016
fmt
4ebbd69 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
fix test
cdb5fab 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'master' of https://github.com/pingcap/tidb into fix_pro…
0872743 
…j_parunion
winoros
winoros reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2020
ichn-hu
ichn-hu approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 3, 2020
@wjhuang2016
Copy link
Member Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@wjhuang2016 merge failed.

@wjhuang2016
Copy link
Member Author

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21229

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit e33b377 into pingcap:master Dec 3, 2020
asiafrank pushed a commit to asiafrank/tidb that referenced this pull request Dec 8, 2020
@wjhuang2016 @asiafrank
planner: add projection if expand virtual generated column (pingcap#2…
9f816ab 
…0478)

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@time-and-fate time-and-fate mentioned this pull request Apr 1, 2021
Closed
@wjhuang2016 wjhuang2016 deleted the fix_proj_parunion branch November 17, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime error: index out of range [8] with length 8
5 participants
@wjhuang2016 @ti-srebot @eurekaka @winoros @ichn-hu