-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add execution retry time in slow log and slow_query and statement_summary (#19625) #20495
Merged
ti-srebot
merged 6 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-5d3cdf5d17e1
Oct 21, 2020
Merged
*: add execution retry time in slow log and slow_query and statement_summary (#19625) #20495
ti-srebot
merged 6 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-5d3cdf5d17e1
Oct 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
component/executor
epic/slow-query
sig/sql-infra
SIG: SQL Infra
sig/execution
SIG execution
type/4.0-cherry-pick
labels
Oct 16, 2020
djshow832
reviewed
Oct 16, 2020
This reverts commit 096b518.
…lease-4.0-5d3cdf5d17e1
…summary (pingcap#19625) Signed-off-by: crazycs520 <crazycs520@gmail.com>
@djshow832 @tangenta PTAL |
@tangenta @djshow832 PTAL |
lzmhhh123
reviewed
Oct 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
djshow832
reviewed
Oct 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Oct 21, 2020
SunRunAway
approved these changes
Oct 21, 2020
ti-srebot
added
status/LGT3
The PR has already had 3 LGTM.
and removed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Oct 21, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Oct 21, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/executor
epic/slow-query
sig/execution
SIG execution
sig/sql-infra
SIG: SQL Infra
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT3
The PR has already had 3 LGTM.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19625 to release-4.0
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Continue to the previous #19487.
This PR do 2 things:
Exec_retry_time
to indicate the time consuming on retry.Exec_retry_time
means the useless retry time consuming. Such retry 10 times, total exec_time is 10 seconds, the last successful execution time is 1 second, so theExec_retry_time
is 9 seconds. The last execution time can be found in thePlan
field in the slow log.exec_retry_count
andexec_retry_time
into system tablestatement_sammary
:Related changes
Check List
Tests
Side effects
Release note