expression, executor: add iso 8601 and timezone support for temporal string literal #20534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label status/WIP |
ichn-hu
changed the title
|
/unlabel status/WIP |
|
/cc @XuHuaiyu |
|
/cc @zz-jason |
|
/run-all-tests |
ichn-hu
changed the title
|
Cast has been pushed down to TiKV, maybe TiKV need to be updated as well? |
wshwsh12
reviewed
Oct 22, 2020
|
/run-all-tests |
|
/cc @SunRunAway |
|
/cc @rebelice |
|
/cc @lzmhhh123 |
|
/run-all-tests |
|
/run-all-tests |
|
/run-check-dev |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
lzmhhh123
approved these changes
Oct 27, 2020
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Oct 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #20670 |
This was referenced Dec 1, 2020
ti-chi-bot
pushed a commit
to tikv/tikv
that referenced
this pull request
Feb 3, 2021
<!-- Thank you for contributing to TiKV! If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed If you want to open the **Challenge Program** pull request, please use the following template: https://raw.githubusercontent.com/tikv/.github/master/.github/PULL_REQUEST_TEMPLATE/challenge-program.md You can use it with query parameters: https://github.com/tikv/tikv/compare/master...${you branch}?template=challenge-program.md --> ### What problem does this PR solve? Problem Summary: previously in TiDB pingcap/tidb#20534 , we supported parsing time string in ISO 8601 format, but the change has not yet ported to TiKV, and this PR gets the job done. ### What is changed and how it works? What's Changed: ### Related changes - Need to cherry-pick to the release branch 4.0. ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test, see https://github.com/pingcap/tidb-test/pull/1149 Side effects - Performance regression - Consumes more CPU ### Release note <!-- bugfixes or new feature need a release note --> - port ISO8601 parsing from TiDB to TiKV's coprocessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #20348 and addtionally close #20507
Problem Summary:
Added timezone support for datetime and timestamp string literal.
What is changed and how it works?
Proposal: see discussions here
What's Changed:
Added parsing, absorbing and converting logic for correct handling of ISO8601 and MySQL 8.0 timezone.
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note