Skip to content

executor: fix panic when set partition handle for index join #20551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #20549

What is changed and how it works?

How it Works: check handles' length whether exceed 0

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • none.

@lzmhhh123 lzmhhh123 added type/bugfix This PR fixes a bug. sig/execution SIG execution labels Oct 21, 2020
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner October 21, 2020 03:06
@lzmhhh123 lzmhhh123 requested review from XuHuaiyu and tiancaiamao and removed request for a team October 21, 2020 03:06
@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@lzmhhh123
Copy link
Contributor Author

/cc @ichn-hu

@ti-srebot ti-srebot requested a review from ichn-hu October 23, 2020 05:30
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 23, 2020
@lzmhhh123
Copy link
Contributor Author

/cc @ichn-hu

@ti-srebot ti-srebot requested a review from ichn-hu October 26, 2020 04:04
@ichn-hu
Copy link
Contributor

ichn-hu commented Oct 26, 2020

/cc @ichn-hu

Already reviewed :D

@ichn-hu ichn-hu mentioned this pull request Nov 3, 2020
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 5, 2020
@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20813

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4e1cbca into pingcap:master Nov 5, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_panic_when_set_partition_handle_for_index_join branch November 5, 2020 06:37
@SunRunAway
Copy link
Contributor

This issue is in the master branch and need not cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexMergeJoin causes panic on NULL value in outer join
5 participants