Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add GOGC under performance section #20872

Merged
merged 5 commits into from
Nov 9, 2020

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Nov 5, 2020

What is changed and how it works?

Add a new config item to the change GOGC setting. #20247 already allows change this setting dynamically.

Release note

  • Allow set GOGC in config file.

@bobotu bobotu added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-4.0 labels Nov 5, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2020
@lysu
Copy link
Contributor

lysu commented Nov 6, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 6, 2020
@bobotu
Copy link
Contributor Author

bobotu commented Nov 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20897
  • 19620

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@bobotu merge failed.

@bobotu
Copy link
Contributor Author

bobotu commented Nov 9, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19620
  • 20857
  • 20099

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 386fb46 into pingcap:master Nov 9, 2020
@bobotu bobotu deleted the gogc-config branch November 9, 2020 03:57
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20922

bobotu added a commit to ti-srebot/tidb that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants