Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix auto-id allocation during statements retry (#20659) #21079

Merged
merged 6 commits into from
Nov 25, 2020

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 16, 2020

Cherry-pick #20659 to release-4.0.

Release note

  • Fix auto-id allocation failed because of transaction's write-conflict retry.

@sre-bot
Copy link
Contributor

sre-bot commented Nov 16, 2020

@github-actions github-actions bot added the sig/execution SIG execution label Nov 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Nov 17, 2020

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2020
@tangenta tangenta requested a review from bb7133 November 17, 2020 10:33
@jebter jebter added this to the v4.0.9 milestone Nov 23, 2020
@bb7133
Copy link
Member

bb7133 commented Nov 25, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 25, 2020
@tangenta
Copy link
Contributor Author

/run-all-tests

@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21171
  • 21146
  • 21238
  • 21283

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 25, 2020
@bb7133 bb7133 merged commit f921f19 into pingcap:release-4.0 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants