expression: Fix unexpected panic when using IF function. #21132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshwsh12
requested review from
qw4990,
hanfei1991 and
XuHuaiyu
and removed request for
a team
wshwsh12
added
type/bugfix
Closed
|
/run-all-tests |
XuHuaiyu
reviewed
Dec 14, 2020
XuHuaiyu
changed the title
ti-srebot
approved these changes
Dec 14, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21711 |
ti-srebot
added a commit
that referenced
this pull request
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15847
Problem Summary:
When rewrite expression, IF(null column,null,null) will get an evalTp TpString. And it will wrap arg0 with isTruth.
Above IF function, there has a CastToReal function.
So the final expression is CastStringToReal(IFString(isTruth(null column), null , null))
In other optimization, maybe it will refactor the expression.
IFString(isTruth(null column), null, null) will be refactored to IFINT(isTruth(null column), null, null)
(See InferType4ControlFuncs and typeInferForNull)
It will cause panic, since CastStringToReal will try to call evalString().
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
Release note