executor: specially handle empty input for apply's outer child aggregate (#20544) #21137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
component/executor
sig/execution
ti-srebot
requested review from
lzmhhh123,
qw4990,
Reminiscent and
SunRunAway
|
@eurekaka you're already a collaborator in bot's repo. |
|
/run-all-tests |
|
@eurekaka Please fix the test. |
eurekaka
force-pushed
the
release-4.0-2e918a2e8fb9
branch
from
0b3ec33
to
3674bf1
Compare
|
/run-check_dev |
eurekaka
force-pushed
the
release-4.0-2e918a2e8fb9
branch
from
3674bf1
to
b2cb566
Compare
|
/run-all-tests tidb-test=pr/ 1138 |
1 similar comment
|
/run-all-tests tidb-test=pr/ 1138 |
|
/run-all-tests tidb-test=pr/1138 |
|
/run-integration-compatibility-test tidb-test=pr/1138 |
|
/run-integration-compatibility-test tidb-test=pr/1138 |
|
/run-all-tests tidb-test=pr/1138 |
|
/run-all-tests tidb-test=pr/1138 |
|
/merge |
|
@zz-jason Oops! This PR requires at least 2 LGTMs to merge. The current number of |
|
PTAL @eurekaka Please resolve conflicts. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
eurekaka
force-pushed
the
release-4.0-2e918a2e8fb9
branch
from
2e52b8a
to
72c17f1
Compare
|
should be merged with https://github.com/pingcap/tidb-test/pull/1138 |
|
/run-all-tests tidb-test=pr/1138 |
|
/run-all-tests tidb-test=pr/1138 |
ti-srebot
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #20544 and #21902 to release-4.0
What problem does this PR solve?
Issue Number: close #13749
Problem Summary:
Wrong query result for Apply operator when its outer child is an aggregate, and the input for the aggregate is empty.
What is changed and how it works?
What's Changed:
If the input for any aggregate in the outer executor tree is empty, we believe this outer row has no match in the apply, since inner child of apply can only reference columns from base outer tables(i.e, aggregate result cannot be referenced in the subquery). Exceptions are cases where outer child contains Join / Union executors, we specially handle them.
Related changes
Check List
Tests
Side effects
N/A
Release note