Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: keep the original data type when doing date arithmetic operations (#20940) #21176

Merged
merged 4 commits into from
Nov 25, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20940 to release-4.0


What problem does this PR solve?

Issue Number: close #20860

Problem Summary: expression: keep the original data type when doing date arithmetic operations

What is changed and how it works?

Keep the original data type when doing date arithmetic operations.

Check List

Tests

  • Unit test

Release note

  • expression: keep the original data type when doing date arithmetic operations

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@qw4990 you're already a collaborator in bot's repo.

@qw4990
Copy link
Contributor

qw4990 commented Nov 25, 2020

/run-all-tests

2 similar comments
@qw4990
Copy link
Contributor

qw4990 commented Nov 25, 2020

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Nov 25, 2020

/run-all-tests

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20889
  • 21273
  • 20998
  • 21244

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@qw4990 qw4990 merged commit 22d3162 into pingcap:release-4.0 Nov 25, 2020
@tiancaiamao tiancaiamao deleted the release-4.0-1d668fa93022 branch December 14, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants