-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: load data statement shoule not be prepared (#21188) #21199
executor: load data statement shoule not be prepared (#21188) #21199
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@ti-srebot you're already a collaborator in bot's repo. |
Please resolve conflicts, @sev7ndayyoo |
/cherry-pick-invite |
This command can used by organization's member only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
…ingcap#21199) Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry-pick #21188 to release-4.0
What problem does this PR solve?
tidb throw unexpected error while execute load data statement in prepare statement
Problem Summary:
The current error is:
‘Load data: previous load data option isn't closed normal’。
expected error is:
‘This command is not supported in the prepared statement protocol yet‘
What is changed and how it works?
What's Changed:
add a logic, if there is load data in prepare statement, return error 'ErrUnsupportedPs'
How it Works:
add a logic, if there is load data in prepare statement, return error 'ErrUnsupportedPs'
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
load data local infile 't1.txt' into table t1 fields terminated by '|' ignore 1 lines
[2020/11/22 21:31:11.349 +08:00] [INFO] [conn.go:801] ["command dispatched failed"] [conn=2199023255557] [connInfo="id:2199023255557, addr:127.0.0.1:56357 status:10, collation:utf8_general_ci, user:root"] [command=Prepare] [status="inTxn:0, autocommit:1"] [sql="load data local infile 't1.txt' into table t1 fields terminated by '|' ignore 1 lines"] [txn_mode=OPTIMISTIC] [err="[executor:1295]This command is not supported in the prepared statement protocol yet"]
Side effects
Release note
load data
statement.