planner: fix incorrect results when using a prefix index with OR condition #21251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
Similar to the PR#8851 |
|
/cc @lzmhhh123 |
|
/cc @winoros |
|
/rebuild |
Closed
ti-srebot
approved these changes
Nov 25, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-cherry-picker |
1 similar comment
|
/run-cherry-picker |
|
@Reminiscent Please help cherry-pick |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 25, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #21234
Problem Summary:
In the previous implementation, when we use a prefix index with OR condition, it will fail to Cut Datum By PrefixLen.
What is changed and how it works?
When we use
detachDNFCondAndBuildRangeForIndexfunction, we take prefix index into consideration.Check List
Tests
Release note