Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: UnionExec supports open limited child executors during execution #21523

Closed
wants to merge 5 commits into from
Closed

executor: UnionExec supports open limited child executors during execution #21523

wants to merge 5 commits into from

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Dec 7, 2020

What problem does this PR solve?

Issue Number: close #21441

Problem Summary:

What is changed and how it works?

What's Changed:
Only open e.concurrency child executor at most during the execution of UnionExec

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note.

@XuHuaiyu XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution needs-cherry-pick-4.0 labels Dec 7, 2020
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner December 7, 2020 05:55
@XuHuaiyu XuHuaiyu requested review from wshwsh12 and removed request for a team December 7, 2020 05:55
@XuHuaiyu XuHuaiyu requested a review from SunRunAway December 7, 2020 05:58
wshwsh12
wshwsh12 reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can Open() Children Executor when worker gets a childID from e.childIDChan.

@XuHuaiyu XuHuaiyu closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support lazy open union children
2 participants
@XuHuaiyu @wshwsh12