expression: handle invalid argument for addtime and subtime function #21600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
reviewed
Dec 9, 2020
| arg0, err := types.ParseTime(sc, d, mysql.TypeDatetime, types.MaxFsp) | ||
| if err != nil { | ||
| return "", err | ||
| sc.AppendWarning(err) |
There was a problem hiding this comment.
Why don't we check the sql_mode to decide whether to return an error or a warning?
e.g. sc.HandleTruncate
There was a problem hiding this comment.
Even in the strict mode, MySQL returns a warning.
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Closed
ti-srebot
added
status/LGT2
ti-srebot
previously approved these changes
Dec 9, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/run-check_dev_2 |
|
/run-integration-copr-test |
wjhuang2016
force-pushed
the
fix_addtime_subtime
branch
from
450e719
to
fddf6cc
Compare
|
/run-integration-copr-test |
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
|
LGTM |
XuHuaiyu
approved these changes
Dec 10, 2020
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #12342
Problem Summary:
Didn't handle the error for the second argument.
What is changed and how it works?
If the second argument is invalid, use
NULLinstead of returning an error.Related changes
Check List
Tests
Side effects
Release note