session: add default_week_format to builtinGlobalVariable (#21511) #21623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/session
sig/sql-infra
|
@kennytm you're already a collaborator in bot's repo. |
|
@wjhuang2016, @xiongjiwei, PTAL. |
1 similar comment
|
@wjhuang2016, @xiongjiwei, PTAL. |
|
@xiongjiwei, @wjhuang2016, PTAL. |
zz-jason
approved these changes
Jan 25, 2021
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21511 to release-4.0
What problem does this PR solve?
Issue Number: close #21510
Problem Summary:
WEEK()did not recognize@@GLOBAL.default_week_formatuntil it has been explicitly read.What is changed and how it works?
What's Changed:
Add
default_week_formatto the list ofbuiltinGlobalVariableso it is initialized when the session starts.How it Works:
Related changes
Check List
Tests
Side effects
Release note
WEEK()call now recognize the global@@default_week_formateven when the session one is not set explicitly.