Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix compare object json type #21703

Merged
merged 2 commits into from
Dec 14, 2020
Merged

types: fix compare object json type #21703

merged 2 commits into from
Dec 14, 2020

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #10460

What is changed and how it works?

How it Works: https://github.com/mysql/mysql-server/blob/ee4455a33b10f1b1886044322e4893f587b319ed/sql/json_dom.cc#L2561

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • fix compare object json type

@lzmhhh123
types: fix compare object json type
7ec38f2 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner December 14, 2020 07:51
@lzmhhh123 lzmhhh123 requested review from SunRunAway and removed request for a team December 14, 2020 07:51
@ti-challenge-bot
Copy link

There is no reward for this challenge pull request, so you can request a reward from @SunRunAway.

Details

Tip : About reward you can refs to reward-command.

Warning: None

@lzmhhh123 lzmhhh123 requested review from XuHuaiyu, wshwsh12 and ichn-hu and removed request for SunRunAway December 14, 2020 07:52
@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Dec 14, 2020
@XuHuaiyu
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2020
@XuHuaiyu XuHuaiyu requested a review from wjhuang2016 December 14, 2020 08:07
@ichn-hu ichn-hu mentioned this pull request Dec 14, 2020
Closed
@lzmhhh123
Copy link
Contributor Author

/run-unit-test

wshwsh12
wshwsh12 reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 14, 2020
@wshwsh12
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21705
  • 21173
  • 21060

@XuHuaiyu
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21060

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit dfbb69d into pingcap:master Dec 14, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_compare_json_object branch December 14, 2020 09:56
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 14, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#21703 to release-4.0
85e9174 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 14, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21718

ti-srebot added a commit that referenced this pull request Jan 25, 2021
@ti-srebot
types: fix compare object json type (#21703) (#21718)
e4526c7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@ichn-hu ichn-hu Awaiting requested review from ichn-hu

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect JSON object compare
4 participants
@lzmhhh123 @XuHuaiyu @wshwsh12 @ti-srebot