util: fix bad number error with DISTINCT when dividing long decimals #21783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Closed
|
LGTM |
Reminiscent
reviewed
Dec 17, 2020
util/codec/codec.go
Outdated
Comment on lines
1217
to
1219
| if frac > mysql.MaxDecimalScale { | ||
| frac = mysql.MaxDecimalScale | ||
| } |
There was a problem hiding this comment.
Should we add this to EncodeDecimal rather than here? Because EncodeDecimal is also called elsewhere, this problem may also occur here?
There was a problem hiding this comment.
Yes, I think so and I have moved the logic to EncodeDecimal.
ti-srebot
approved these changes
Dec 18, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Apr 21, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #24188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15563
Problem Summary:
What is changed and how it works?
What's Changed:
fix bad number error with DISTINCT when dividing long decimals
How it Works:
set precision and frac before calling
EncodeDecimalRelated changes
Check List
Tests
Side effects
Release note