Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: double type column from table should ignore its decimal #21788

Merged
merged 5 commits into from
Dec 22, 2020
Merged

server: double type column from table should ignore its decimal #21788

merged 5 commits into from
Dec 22, 2020

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #21692

What is changed and how it works?

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • double type column from table should ignore its decimal

@lzmhhh123
server: double type column from table should ignore its decimal
1c6d7d6 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123
fix
5f029e3 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@ichn-hu ichn-hu mentioned this pull request Dec 15, 2020
Closed
@lzmhhh123 lzmhhh123 added the type/bugfix This PR fixes a bug. label Dec 16, 2020
@XuHuaiyu
Copy link
Contributor

Any test case?

@XuHuaiyu XuHuaiyu requested a review from morgo December 17, 2020 03:42
@XuHuaiyu
Copy link
Contributor

@lzmhhh123 Please address the comment.

@XuHuaiyu XuHuaiyu requested a review from wshwsh12 December 21, 2020 08:25
@lzmhhh123
add test
adcb41b 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
XuHuaiyu
XuHuaiyu reviewed Dec 21, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2020
wshwsh12
wshwsh12 reviewed Dec 21, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 21, 2020
@wshwsh12
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21776

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 21, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lzmhhh123 merge failed.

@lzmhhh123
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21776

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 32d8cad into pingcap:master Dec 22, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 22, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#21788 to release-4.0
2df4672 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 22, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21916

@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_double_precise branch December 22, 2020 03:29
ti-srebot added a commit that referenced this pull request Jan 26, 2021
@ti-srebot
server: double type column from table should ignore its decimal (#21788…
6f41739 
…) (#21916)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@b41sh b41sh mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOUBLE type can't keep precise
4 participants
@lzmhhh123 @XuHuaiyu @wshwsh12 @ti-srebot