-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the fail when we compare multi fields in the subquery (#21699) #21808
Merged
qw4990
merged 3 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-e01a1422377c
Jan 26, 2021
Merged
planner: fix the fail when we compare multi fields in the subquery (#21699) #21808
qw4990
merged 3 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-e01a1422377c
Jan 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
sig/planner
SIG: Planner
type/4.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Dec 15, 2020
@Reminiscent you're already a collaborator in bot's repo. |
/run-all-tests |
qw4990
reviewed
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @XuHuaiyu @lzmhhh123 |
lzmhhh123
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21699 to release-4.0
What problem does this PR solve?
Issue Number: close #13551 close #21674
Problem Summary:
When we use
(SELECT c1, c2 FROM t2 LIMIT 1) = ANY (SELECT c1, c2 FROM t1)
in thewhere
statement, theexpressionRewrite.ctxStack
will store the result value ofSELECT c1, c2 FROM t2 LIMIT 1
. So in issue#21674, when the value of c1 is zero, the plan will be convert totableDual
.What is changed and how it works?
So, we should set
expressionRewrite.asScalar = true
likehandleInSubquery
function. It will use the parent expression's last column from the schema to represents whether the condition is matched(https://github.com/pingcap/tidb/blob/master/planner/core/expression_rewriter.go#L558-L561).Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note