Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add a switch for alter partition alter placement #21833

Merged
merged 8 commits into from
Dec 18, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Dec 16, 2020

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

add a switch for alter partition alter placement (GEO Partition Feature), since this feature hasn't been GA in sprint1, so we add a switch for it.

What is changed and how it works?

add a switch for alter partition alter placement

Check List

Tests

  • Unit test

Release note

  • ddl: add a switch for alter partition alter placement.

Signed-off-by: AilinKid <314806019@qq.com>
@sre-bot
Copy link
Contributor

sre-bot commented Dec 16, 2020

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@AilinKid AilinKid changed the title ddladd a switch for alter partition alter placement ddl: add a switch for alter partition alter placement Dec 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Dec 16, 2020

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Dec 16, 2020
@AilinKid AilinKid requested a review from djshow832 December 16, 2020 07:28
sessionctx/variable/tidb_vars.go Outdated Show resolved Hide resolved
sessionctx/variable/tidb_vars.go Outdated Show resolved Hide resolved
.
Signed-off-by: AilinKid <314806019@qq.com>
ddl/ddl_api.go Outdated Show resolved Hide resolved
.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 17, 2020
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 17, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 17, 2020
@djshow832
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit b74e8b5 into pingcap:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants