Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression, types: fix datetime and year comparison error (#20233) #21881

Merged
merged 9 commits into from
Jan 27, 2021
Merged

expression, types: fix datetime and year comparison error (#20233) #21881

merged 9 commits into from
Jan 27, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20233 to release-4.0

What problem does this PR solve?

Issue Number: close #20121

Problem Summary:

What is changed and how it works?

For Datetime vs Year, Date vs Year, Timestamp vs Year comparison, CompareTime should be used, and Year should be converted to Time before comparing.

What's Changed:

expression/builtin_cast.go
types/time.go

How it Works:

For Datetime vs Year, Date vs Year, Timestamp vs Year comparison, CompareTime should be used, and Year should be converted to Time before comparing.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@ti-srebot
cherry pick pingcap#20233 to release-4.0
b41a5ea 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 18, 2020
Merged
@ti-srebot ti-srebot added component/expression contribution This PR is from a community contributor. type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Dec 18, 2020
@ti-srebot ti-srebot added this to the 4.0.0 milestone Dec 18, 2020
@ti-srebot
Copy link
Contributor Author

@XuHuaiyu you're already a collaborator in bot's repo.

@jebter jebter modified the milestones: 4.0.0, v4.0.10 Jan 7, 2021
@jebter jebter modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
@zhongzc
Copy link
Contributor

zhongzc commented Jan 25, 2021

Does this PR need to merge into release-4.0? @XuHuaiyu

qw4990
qw4990 reviewed Jan 26, 2021
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/run-all-tests

lzmhhh123
lzmhhh123 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2021
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21945
  • 22136
  • 22119
  • 21853
  • 22174

@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21945
  • 22136
  • 22119
  • 21853
  • 22174
  • 22527
  • 22527
  • 22148
  • 22174
  • 22119
  • 21976

@zhongzc
Copy link
Contributor

zhongzc commented Jan 26, 2021

/run-all-tests tikv=pr/9299

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Jan 27, 2021

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Jan 27, 2021

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Jan 27, 2021

Need to fix coprocessor first.

@zhongzc
Copy link
Contributor

zhongzc commented Jan 27, 2021

/run-all-tests tikv=pr/9299

@zhongzc
Copy link
Contributor

zhongzc commented Jan 27, 2021

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zhongzc
Copy link
Contributor

zhongzc commented Jan 27, 2021

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zhongzc
Copy link
Contributor

zhongzc commented Jan 27, 2021

/run-integration-copr-test

1 similar comment
@zhongzc
Copy link
Contributor

zhongzc commented Jan 27, 2021

/run-integration-copr-test

@zhongzc
Copy link
Contributor

zhongzc commented Jan 27, 2021

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 167edac into pingcap:release-4.0 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees

@XuHuaiyu XuHuaiyu

Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.11
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @zhongzc @qw4990 @lzmhhh123 @jebter @XuHuaiyu