executor, session, sessionctx: fix the error message of read-only variable is corrupted #21948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @bb7133 |
|
|
SunRunAway
reviewed
Dec 22, 2020
session/session_test.go
Outdated
| func (s *testSessionSerialSuite) TestIssue21944(c *C) { | ||
| tk1 := testkit.NewTestKitWithInit(c, s.store) | ||
| _, err := tk1.Exec("set @@tidb_current_ts=1;") | ||
| c.Assert(err.Error(), Equals, "[variable:1621]tidb_current_ts variable 'tidb_current_ts' is read-only. Use SET tidb_current_ts to assign the value") |
There was a problem hiding this comment.
This is different from the expected error message described in #21944
Closed
morgo
reviewed
Dec 22, 2020
|
PTAL @SunRunAway @morgo |
morgo
reviewed
Dec 23, 2020
TszKitLo40
changed the title
|
LGTM |
ti-srebot
approved these changes
Dec 23, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Tjianke
pushed a commit
to Tjianke/tidb
that referenced
this pull request
Dec 25, 2020
…iable is corrupted (pingcap#21948)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #21944
Problem Summary:
What is changed and how it works?
What's Changed:
fix the error message of read-only variable is corrupted
How it Works:
format the error message when read-only variable is set
Check List
Tests
Side effects
Release note