Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add plancodec id for all type TableScan/IndexScan. (#21935) #21964

Merged
merged 5 commits into from
Jan 27, 2021
Merged

planner: add plancodec id for all type TableScan/IndexScan. (#21935) #21964

merged 5 commits into from
Jan 27, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21935 to release-4.0

What problem does this PR solve?

Issue Number: close #20833

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Unify the plan code for explain result and slow log.

@wshwsh12 @ti-srebot
cherry pick pingcap#21935 to release-4.0
050a63b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 23, 2020
Merged
@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra sig/planner SIG: Planner type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Dec 23, 2020
@ti-srebot ti-srebot added this to the 4.0.0 milestone Dec 23, 2020
@ti-srebot
Copy link
Contributor Author

@wshwsh12 you're already a collaborator in bot's repo.

@jebter jebter modified the milestones: 4.0.0, v4.0.10 Jan 7, 2021
@jebter jebter modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
@wshwsh12
Copy link
Contributor

@Reminiscent @XuHuaiyu PTAL

Reminiscent
Reminiscent reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 27, 2021

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Jan 27, 2021

�/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Jan 27, 2021

/run-unit-test

qw4990
qw4990 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 27, 2021
@qw4990 qw4990 merged commit a33b350 into pingcap:release-4.0 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@wshwsh12 wshwsh12

Labels
sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.11
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @wshwsh12 @qw4990 @Reminiscent @jebter