Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix select into outfile with year type column has no data #22175

Merged
merged 4 commits into from
Jan 5, 2021

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #22159

Problem Summary:

What is changed and how it works?

add year type column in dumpToOutfile

Check List

Tests

  • Unit test

Release note

  • fix a bug that select into outfile has no data with year column type

@xiongjiwei xiongjiwei requested a review from a team as a code owner January 5, 2021 05:51
@xiongjiwei xiongjiwei requested review from wshwsh12 and removed request for a team January 5, 2021 05:51
@github-actions github-actions bot added the sig/execution SIG execution label Jan 5, 2021
@xiongjiwei
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 5, 2021
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 5, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 5, 2021
@wjhuang2016
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@wshwsh12
Copy link
Contributor

wshwsh12 commented Jan 5, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 85d8d06 into pingcap:master Jan 5, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 5, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 5, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
@xiongjiwei xiongjiwei deleted the s-i-o branch September 23, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select into outfile time1 year(4) default '2030', Inconsistent data 「tidb 4.0.9 vs mysql 5.7」
5 participants