Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: speed up Column.VecEvalReal by using MergeNulls #22191

Merged
merged 8 commits into from
Feb 17, 2021
Merged

expression: speed up Column.VecEvalReal by using MergeNulls #22191

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a0ccaed
use Column.MergeNulls to improve efficiency
Tjianke Jan 4, 2021
6166b1f
remove superfluous else indentation
Tjianke Jan 4, 2021
2d70223
Merge branch 'master' into mergeNulls
Tjianke Jan 5, 2021
0750f9a
add panic for unequal length
Tjianke Jan 5, 2021
1f2f6b8
Merge branch 'mergeNulls' of https://github.com/Tjianke/tidb into mer…
Tjianke Jan 5, 2021
cfcb62e
fmt
Tjianke Jan 6, 2021
9e6297f
Merge branch 'master' into mergeNulls
Tjianke Jan 6, 2021
1a3f4ea
Merge branch 'master' into mergeNulls
ti-srebot Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions expression/column.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,13 +257,12 @@ func (col *Column) VecEvalReal(ctx sessionctx.Context, input *chunk.Chunk, resul
}
return nil
}
result.MergeNulls(src)
for i := range f32s {
// TODO(zhangyuanjia): speed up the way to manipulate null-bitmaps.
if src.IsNull(i) {
result.SetNull(i, true)
} else {
f64s[i] = float64(f32s[i])
if result.IsNull(i) {
continue
}
f64s[i] = float64(f32s[i])
}
return nil
}
Expand Down