bindinfo: avoid duplicate bindings caused by concurrent baseline capture (#22182) #22295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
epic/sql-plan-management
sig/planner
|
@eurekaka you're already a collaborator in bot's repo. |
qw4990
reviewed
Jan 8, 2021
bindinfo/bind_test.go
Outdated
| @@ -1761,6 +1761,54 @@ func (s *testSuite) TestDMLIndexHintBind(c *C) { | |||
| c.Assert(tk.MustUseIndex("delete from t where b = 1 and c > 1", "idx_c(c)"), IsTrue) | |||
| } | |||
|
|
|||
| <<<<<<< HEAD | |||
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
eurekaka
force-pushed
the
release-4.0-0a4ec0da2b80
branch
from
b4e236b
to
0af3c50
Compare
ti-srebot
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22182 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr 22295After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #22178
Problem Summary:
Duplicate bindings for a same original_sql.
What is changed and how it works?
What's Changed:
Call
CreateBindRecordinstead ofAddBindRecordinCaptureBaselines.How it Works:
AddBindRecordonly checks the duplicate in binding cache, whileCreateBindRecordwould remove duplicate bindings inmysql.bind_infounconditionally.Related changes
Check List
Tests
Side effects
N/A
Release note