-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: reorder inner joins simplified from outer joins (#22392) #22402
Merged
qw4990
merged 1 commit into
pingcap:release-4.0
from
ti-srebot:release-4.0-dd5bfc39490e
Jan 18, 2021
Merged
planner: reorder inner joins simplified from outer joins (#22392) #22402
qw4990
merged 1 commit into
pingcap:release-4.0
from
ti-srebot:release-4.0-dd5bfc39490e
Jan 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
ti-srebot
added
sig/planner
SIG: Planner
type/4.0-cherry-pick
type/enhancement
The issue or PR belongs to an enhancement.
labels
Jan 15, 2021
@eurekaka you're already a collaborator in bot's repo. |
eurekaka
force-pushed
the
release-4.0-dd5bfc39490e
branch
from
January 15, 2021 07:57
2a07683
to
6d17216
Compare
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
eurekaka
force-pushed
the
release-4.0-dd5bfc39490e
branch
from
January 15, 2021 08:16
6d17216
to
69bd8f0
Compare
/run-all-tests |
lzmhhh123
reviewed
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reminiscent
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jan 15, 2021
qw4990
approved these changes
Jan 18, 2021
ti-srebot
added
status/LGT3
The PR has already had 3 LGTM.
and removed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/LGT3
The PR has already had 3 LGTM.
type/enhancement
The issue or PR belongs to an enhancement.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22392 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22402
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #22384
Problem Summary:
Plan for query containing outer join is not optimal.
What is changed and how it works?
What's Changed:
Add
flagJoinReOrder
when buildingLogicalJoin
regardless of the join types.joinReorderSolver
itself can check if the reorder is applicable.How it Works:
Related changes
Check List
Tests
Side effects
N/A
Release note