executor: metrics slow query is divided into internal and general (#22350) #22405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
sig/execution
|
@ti-srebot you're already a collaborator in bot's repo. |
|
@jackysp PTAL |
|
PTAL @lysu |
|
LGTM |
ti-srebot
added
status/LGT2
jackysp
approved these changes
Jan 20, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22350 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22405After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Currently
slow query metricscontainsinternal SQL,These
internal SQLmay affect customers and DBA analysis problems, so add label to distinguishinternalandgeneral.What is changed and how it works?
What's Changed:
Slow queryis divided intointernalandgenerallabelsHow it Works:
Slow queryis divided intointernalandgenerallabelsRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note