-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: fix subQuery at projection in only_full_group #22416
base: master
Are you sure you want to change the base?
Conversation
There is no reward for this challenge pull request, so you can request a reward from @lzmhhh123. |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
/rebuild |
PTAL @eurekaka |
# Conflicts: # planner/core/integration_test.go
/rebuild |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9944d1e08b01571e3513e28492c85cb5af3e99c8 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22416 +/- ##
=================================================
+ Coverage 61.8770% 73.6397% +11.7627%
=================================================
Files 885 971 +86
Lines 282407 308635 +26228
=================================================
+ Hits 174745 227278 +52533
+ Misses 93934 66989 -26945
- Partials 13728 14368 +640 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR Title Format:
What problem does this PR solve?
Issue Number: close #17731
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note
core:fix query with missing column in group by is executed