-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: RFC for better staleness read syntax. #22506
Conversation
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
/rebuild |
I think we can support the simple syntax, meanwhile, we can also support the full syntax. like |
PTAL @morgo |
Time travel queries are not part of MySQL, but they are part of MariaDB and the SQL:2011 standard. The syntax is in this FR: #18672 I don't believe either specify syntax that is transaction scoped, but I can see this can be useful. |
There are two statements related to staleness read, the last statement is time travel read. A unified syntax for both cases would be nice. |
START TRANSACTION READ ONLY WITH TIMESTAMP BOUND READ TIMESTAMP '2019-11-04 00:00:00' | ||
``` | ||
|
||
The redundant words ```READ ONLY``` and ```TIMESTAMP BOUND``` as well as ```READ``` are removed for clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think READ ONLY
warnings the txn must be a read-only transaction, rather than the user may do write operator in the transaction.
Refer to #18672 @sunxiaoguang maybe we can use |
I'm not sure, maybe |
How about discussing more at #22765? |
We have a conclusion: #22765 (comment) |
Great. Since the detail discussion is not here, maybe we should close this issue for now. What do you think @nolouch? |
Yes, I closed #22505, and I will update the RFC document in another PR. |
Closed as resolved in #22765 |
Signed-off-by: Xiaoguang Sun sunxiaoguang@zhihu.com
What problem does this PR solve?
Issue Number: 22505
Problem Summary:
Existing timestamp bound read SQL syntax is over complicate and hard to use
What is changed and how it works?
Propose new syntax to staleness read and deprecates existing timestamp bounds read SQL syntax which is over complicate.
What's Changed:
RFC documents.
Check List
Tests
Release note